Skip to content

[FEATURE REQUEST] Edit link over a space#4817

Open
joragua wants to merge 16 commits intomasterfrom
feature/edit_space_link
Open

[FEATURE REQUEST] Edit link over a space#4817
joragua wants to merge 16 commits intomasterfrom
feature/edit_space_link

Conversation

@joragua
Copy link
Copy Markdown
Contributor

@joragua joragua commented Apr 9, 2026

Related Issues

App: #4756

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Apr 9, 2026
@joragua joragua force-pushed the feature/edit_space_link branch from 68b51f8 to 02b0e0e Compare April 9, 2026 11:28
@joragua joragua linked an issue Apr 9, 2026 that may be closed by this pull request
12 tasks
@joragua joragua force-pushed the feature/edit_space_link branch 3 times, most recently from 3c30678 to c5a3011 Compare April 10, 2026 08:26
@jesmrec jesmrec force-pushed the feature/edit_space_link branch from 064f233 to dc46bde Compare April 10, 2026 11:27
@joragua joragua force-pushed the feature/edit_space_link branch from dc46bde to 8b936a5 Compare April 13, 2026 11:36
@joragua joragua closed this Apr 13, 2026
@joragua joragua force-pushed the feature/edit_space_link branch from 8b936a5 to 6ac162b Compare April 13, 2026 11:45
@jesmrec jesmrec reopened this Apr 13, 2026
@joragua joragua force-pushed the feature/edit_space_link branch 3 times, most recently from 076c8ac to d51f23a Compare April 17, 2026 12:54
@joragua joragua force-pushed the feature/edit_space_link branch from 4822a5c to 6f9dd9c Compare April 22, 2026 07:30
@joragua joragua marked this pull request as ready for review April 22, 2026 07:39
@joragua joragua requested a review from jesmrec April 22, 2026 07:40
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments from my side @joragua!

@joragua joragua force-pushed the feature/edit_space_link branch 2 times, most recently from 0731cc7 to a5263f7 Compare April 27, 2026 10:49
@joragua joragua force-pushed the feature/edit_space_link branch from a5263f7 to 30b0258 Compare April 27, 2026 10:52
@joragua joragua requested a review from jesmrec April 27, 2026 11:14
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR approved, moving to QA

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Apr 28, 2026

(1) (improvement)

It would be handy to add a (x) in the link name row to remove the name with just one click. What do you think? (iOS has it)

Xiaomi Redmi Note 13, Android 15
2617e171

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Apr 28, 2026

(2)

This is how a link with Secret File Drop permission and expiration date looks like:

Screenshot 2026-04-28 at 12 26 54

The year is elipisized and not visible, but, the timestamp 23:59 is visible. I think that the complete date would be more interesting to show.

Xiaomi Redmi Note 13, Android 15
2617e171

@joragua joragua force-pushed the feature/edit_space_link branch from 95f28ec to 3e99045 Compare April 28, 2026 12:01
@joragua
Copy link
Copy Markdown
Contributor Author

joragua commented Apr 28, 2026

(1) should be addressed in commit 1adf344 -> When the edit text for the link name is focused, all the text is selected. In the whole app we don't have an (X) icon to clear text so I didn't go with that approach. Let me know if it's OK for you @jesmrec 😄

(2) should be fixed in commit 3e99045 -> The expiration date is now ellipsized at the end instead of in the middle in order to display the full date (not the timestamp)

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Apr 28, 2026

(3)

  1. In a server with mandatory password for writeable links, click on the pencil icon of a link with Can view permission and password not set
  2. Change permission to Can edit
  3. Click on Set and Generate to create a new password (or type it yourself)
  4. Click on Set to submit the edition

Current:

Snackbar with Public link could not be edited because unknown error.

Server returns 400 on the PATCH request. Error 400 happens because the PATCH tries to update the link with password mandatory (step 2) and password is not set yet.

Expected

Link updated correctly.

Probably, the requests have to be swapped, as iOS does.

Not sure if the 400 should be handled as well

Xiaomi Redmi Note 13, Android 15
2617e171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Edit a link over a space

2 participants